chore: Update to Smithy 1.49.0 #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
May 21, 2024
| @@ -285,7 +285,7 @@ fun Parameter.toSymbol(): Symbol { | |||
| val swiftType = when (type) { | |||
| ParameterType.STRING -> SwiftTypes.String | |||
| ParameterType.BOOLEAN -> SwiftTypes.Bool | |||
| else -> throw CodegenException("Unsupported parameter type: $type") | |||
| ParameterType.STRING_ARRAY -> SwiftTypes.StringArray | |||
There was a problem hiding this comment.
Add STRING_ARRAY case and eliminate the else so this fails to compile when a new ParameterType is added in the future.
jbelkins
commented
May 21, 2024
| @@ -86,7 +86,7 @@ fun Parameter.toSymbol(): Symbol { | |||
| val swiftType = when (type) { | |||
| ParameterType.STRING -> SwiftTypes.String | |||
| ParameterType.BOOLEAN -> SwiftTypes.Bool | |||
| else -> throw CodegenException("Unsupported parameter type: $type") | |||
| ParameterType.STRING_ARRAY -> SwiftTypes.StringArray | |||
There was a problem hiding this comment.
Same change as in AuthSchemeResolverGenerator above.
sichanyoo
approved these changes
May 22, 2024
sichanyoo
requested changes
May 22, 2024
smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/SwiftTypes.kt
Show resolved
Hide resolved
dayaffe
approved these changes
May 22, 2024
sichanyoo
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
awslabs/aws-sdk-swift#1513
Description of changes
Updates Smithy from 1.47.0 to 1.49.0.
There are corresponding changes in aws-sdk-swift PR awslabs/aws-sdk-swift#1515 .
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.