Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add integration tests for services with specific customizations #1587

Closed
2 tasks
dayaffe opened this issue Jun 21, 2024 · 0 comments
Closed
2 tasks

feat: Add integration tests for services with specific customizations #1587

dayaffe opened this issue Jun 21, 2024 · 0 comments
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Jun 21, 2024

Describe the feature

We should have integration tests for services with specific customizations. E.g., AWSGlacier has specific customizations such as the Sha256Middleware.

Use Case

For ensuring code changes don't break services with customizations.

Proposed Solution

No response

Other Information

Other than S3 which we already have tests for, there're Glacier, Route53, APIGateway, and MachineLearning.
Related ticket: #1027

Note:

  • APIGateway's customization that adds a header to request is straightforward and already is in correct order.
  • MachineLearning's customization requires machine learning model setup; revisit later if needed.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dayaffe dayaffe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2024
@sichanyoo sichanyoo self-assigned this Jun 26, 2024
@dayaffe dayaffe changed the title feat: Add integration tests for Glacier feat: Add integration tests for Glacier / other services with specific customizations Jun 26, 2024
@sichanyoo sichanyoo changed the title feat: Add integration tests for Glacier / other services with specific customizations feat: Add integration tests for services with specific customizations Jun 28, 2024
@sichanyoo sichanyoo added the needs-triage This issue or PR still needs to be triaged. label Jul 1, 2024
@jbelkins jbelkins removed the needs-triage This issue or PR still needs to be triaged. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

3 participants