chore: Integration test additions for Glacier & Route53 #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
reviewed
Jul 9, 2024
| } catch is InvalidChangeBatch { | ||
| // no-op | ||
| } catch { | ||
| XCTFail("Expected InvalidChangeBatch error, but it was not thrown.") |
There was a problem hiding this comment.
Maybe clarify this message and log the error that was actually thrown
There was a problem hiding this comment.
Changed as suggested.
| body: .data("Hello World".data(using: .utf8)), | ||
| vaultName: vaultName | ||
| ) | ||
| // Wait until vault is available |
There was a problem hiding this comment.
excellent use of waiter in integration tests
jbelkins
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1587
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.