Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back maxAttempts config back to AWS config #1735

Closed
sichanyoo opened this issue Sep 12, 2024 · 0 comments
Closed

Add back maxAttempts config back to AWS config #1735

sichanyoo opened this issue Sep 12, 2024 · 0 comments
Assignees
Labels
bug This issue is a bug. feature-request A feature should be added or improved.

Comments

@sichanyoo
Copy link
Contributor

sichanyoo commented Sep 12, 2024

Background

During the client configuration rework for SRA compliance, a previously exposed optional config value for number of retries to do for a failed request got scrapped. It was part of AWSClientConfiguration and had the variable name maxAttempts, and it was added with this PR.

But the maxAttempts config option did not transfer over to the new corresponding config AWSDefaultClientConfiguration added with this rework PR.

The developer guide for the SDK currently advises SDK users to directly manipulate the retryStrategyOptions option, but that is NOT what we want to encourage the users do. Instead, users should generally only use the awsRetryMode and the maxAttempts options. The values configured on these two fields get used automatically to resolve the retryStrategyOptions used by the client.

But maxAttempts got scrapped, which is an issue.

To-do

Add back maxAttempts config by adding it to AWSDefaultClientConfiguration.
Update codegen / runtime default provider logic as needed to have the configured value for maxAttempts take effect.

Note

(Sorta) Tracks: smithy-lang/smithy-swift#818

  • After this config is added back, developer guide should scrap its current configure retry section and re-write it based on the two config fields (awsRetryMode and maxAttempts options) that we actually want to encourage users to use.
@sichanyoo sichanyoo self-assigned this Sep 12, 2024
@sichanyoo sichanyoo changed the title Tracking ticket for sorting out retry config Tracking ticket for sorting out retry config info in docs Sep 12, 2024
@sichanyoo sichanyoo changed the title Tracking ticket for sorting out retry config info in docs Add back maxAttempts config back to relevant config Sep 12, 2024
@sichanyoo sichanyoo changed the title Add back maxAttempts config back to relevant config Add back maxAttempts config back to config Sep 12, 2024
@sichanyoo sichanyoo changed the title Add back maxAttempts config back to config Add back maxAttempts config back to AWS config Sep 12, 2024
@sichanyoo sichanyoo added bug This issue is a bug. feature-request A feature should be added or improved. labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants