fix!: Retry config #1744
fix!: Retry config #1744
Conversation
… user for awsRetryMode and maxAttempts actually get used when resolving retryStrategyOptions.
…t by user when constructing retry strategy options.
| @@ -99,17 +99,30 @@ public class AWSClientConfigDefaultsProvider { | |||
| return resolvedRetryMode! | |||
There was a problem hiding this comment.
GH diff is being a bit wonky here. I just added private static func maxAttempts, and changed the function signature of func retryStrategyOptions to take in arguments (the top level config awsRetryMode and maxAttempts) at call site.
| @@ -31,9 +31,19 @@ public protocol AWSDefaultClientConfiguration { | |||
|
|
|||
There was a problem hiding this comment.
Adds back the lost maxAttempts option back to config. Let's welcome our poor option that finally found its way back home.
| @@ -15,10 +15,13 @@ public class DefaultAWSClientPlugin: Plugin { | |||
| } | |||
There was a problem hiding this comment.
Now that defaults provider for retry strategy options actually takes in user-exposed config now, let's use em.
| @@ -67,7 +67,7 @@ class AWSHttpProtocolServiceClient( | |||
| ConfigProperty( | |||
There was a problem hiding this comment.
In initializers that take in arguments for awsRetryMode and maxAttempts, default value for retry strategy options should be defaults provider function call using those arguments.
In initializer that doesn't take in arguments for awsRetryMode and maxAttempts but needs to set retry strategy options value to something that isn't nil (e.g., the region initializer), we can't pass in any values to defaults provider method call.
| @@ -39,5 +39,6 @@ class AWSDefaultClientConfiguration : ClientConfiguration { | |||
| { it.format("\$N.retryMode()", AWSClientRuntimeTypes.Core.AWSClientConfigDefaultsProvider) }, | |||
There was a problem hiding this comment.
Adds the new config value in codegen side.
Issue #
Description of changes
maxAttemptsthat allows SDK users to configure number of retries the SDK should make without having to directly manipulate theretryStategyOptionsconfig option.maxAttemptsandawsRetryModeconfig values set by the user actually get used when we resolve the defaultretryStrategyOptionsconfig.New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.