-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve the iOS CI job #1000
Conversation
distribution: corretto | ||
java-version: 17 | ||
- name: Setup xcbeautify | ||
run: HOMEBREW_NO_AUTO_UPDATE=1 brew install xcbeautify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why set HOMEBREW_NO_AUTO_UPDATE
? Each CI run will be re-installing xcbeautify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Homebrew will automatically update whenever it's invoked, unless this var is set.
The Github CI machines are often pretty far behind on the Homebrew repo, so updating homebrew takes a fair amount of time.
xcbeautify
itself doesn't get updated very often, and I'm OK with being behind the latest version.
Description of changes
Replaces the iOS Github CI job with a new job having the following improvements:
xcodebuild
to build & test the SDK using the iOS Simulator.xcbeautify
is used to clean up & reduce the volume of Swift logs, and to reduce build time.Once this job has had an opportunity to run for a while and proves reliable & efficient, I plan to adapt it for use with other CI jobs as well.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.