Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade the Mac CI task #1053

Merged
merged 13 commits into from
Jul 3, 2023
Merged

chore: Upgrade the Mac CI task #1053

merged 13 commits into from
Jul 3, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Jun 28, 2023

Description of changes

Builds & tests Mac & iOS platforms on oldest & newest Xcode, using a single job matrixed to run 4 combinations of OS, Xcode, and platform.

  • Eliminates dependence on CRT builder script, and all of the config for that script is removed.
  • No need for Github or AWS credentials on this workflow anymore. AWS credentials may be removed from this repo after merge.
  • Allows for easy add of new Apple platforms (TV, watch, etc.) in the future.

Note: Update the required CI checks to reflect the new names after this PR merges.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins changed the title Upgrade the Mac CI task chore: Upgrade the Mac CI task Jun 28, 2023
@jbelkins jbelkins marked this pull request as ready for review June 28, 2023 21:15
@jbelkins jbelkins requested a review from waahm7 June 28, 2023 21:19
@jbelkins jbelkins merged commit e4ca366 into main Jul 3, 2023
@jbelkins jbelkins deleted the jbe/new_mac_ci branch July 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants