Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch CI log processor from xcbeautify to xcpretty #1075

Merged
merged 6 commits into from
Aug 11, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Aug 10, 2023

Description of changes

Recently CI builds started failing on macOS 11 CI jobs because xcbeautify (installed via Homebrew) was updated to not support macOS 11 & Xcode 13. xcbeautify is not published to Homebrew with versioning, so it is difficult to specify an exact xcbeautify version to be installed.

The solution is to use xcpretty instead of xcbeautify to format logs. xcpretty is slower and less recently updated, but comes pre-installed on every Github mac runner.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested review from dayaffe and sichanyoo August 11, 2023 14:36
@jbelkins jbelkins changed the title fix: Pin xcbeautify to a version that supports our CI environment fix: Switch CI log processor from xcbeautify to xcpretty Aug 11, 2023
@jbelkins jbelkins marked this pull request as ready for review August 11, 2023 14:37
Copy link
Contributor

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jbelkins jbelkins merged commit dd89012 into main Aug 11, 2023
@jbelkins jbelkins deleted the jbe/pin_xcbeautify branch August 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants