feat: add process credential provider #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Status Update: This PR is on-hold until the next release of CRT and companion version bump in Swift SDK |
jbelkins
reviewed
Aug 15, 2023
...e/AWSClientRuntimeTests/Auth/CredentialsProvidersTests/ProcessCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
|
/test |
jbelkins
requested changes
Aug 16, 2023
...e/AWSClientRuntimeTests/Auth/CredentialsProvidersTests/ProcessCredentialsProviderTests.swift
Show resolved
Hide resolved
...e/AWSClientRuntimeTests/Auth/CredentialsProvidersTests/ProcessCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
sichanyoo
reviewed
Aug 16, 2023
Sources/Core/AWSClientRuntime/Auth/CredentialsProviders/ProcessCredentialsProvider.swift
Outdated
Show resolved
Hide resolved
sichanyoo
requested changes
Aug 16, 2023
sichanyoo
approved these changes
Aug 16, 2023
jbelkins
requested changes
Aug 17, 2023
...lsProviders/ProcessCredentialsProviderIntegrationTests/ProcessCredentialsProviderTests.swift
Outdated
Show resolved
Hide resolved
|
/test |
jbelkins
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Process credentials" are described in a SEP: --/seps/accepted/shared/extensible-creds.md
Since CRT is adding a Process Credential Provider (see ticket: awslabs/aws-crt-swift#177) we need to create a wrapper for CRT's process credential provider that is located in the SDK.
Issue #
#1073
Description of changes
Create a wrapper class ProcessCredentialsProvider with companion unit tests
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.