Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct serde for errors in event streams #1120

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Sep 12, 2023

Issue #

#1100

Description of changes

Fixes serializers / deserializers for errors that are embedded in event streams, by accounting for the custom error properties being namespaced under properties.

To show the effect of this change clearly, the model for SageMaker with the breaking change is included, and code has been regenerated for all AWS services.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins
Copy link
Contributor Author

/test

Copy link
Contributor

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sichanyoo sichanyoo self-requested a review September 13, 2023 00:12
Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jbelkins jbelkins merged commit 93696f9 into main Sep 13, 2023
10 checks passed
@jbelkins jbelkins deleted the jbe/event_stream_error_fix branch September 13, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants