Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Package.swift based on codegen and add AWSSTS as ECS integration test dependency #1136

Merged
merged 3 commits into from
Sep 19, 2023
Merged

fix: Update Package.swift based on codegen and add AWSSTS as ECS integration test dependency #1136

merged 3 commits into from
Sep 19, 2023

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Sep 19, 2023 •
edited
Loading

Issue #

Description of changes

  • Update Package.swift to include changes that were added to codegen
  • Add AWSSTS as ECS integration test dependency

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dayaffe
Copy link
Contributor Author

dayaffe commented Sep 19, 2023

/test

jbelkins
jbelkins approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending all-green CI

@dayaffe dayaffe merged commit 543983d into main Sep 19, 2023
10 checks passed
@dayaffe dayaffe deleted the day/package-swift-fix branch September 19, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelkins jbelkins jbelkins approved these changes

@sichanyoo sichanyoo Awaiting requested review from sichanyoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dayaffe @jbelkins