Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update swift version, macos, and xcode #1156

Merged
merged 15 commits into from
Sep 29, 2023
Merged

Conversation

dayaffe
Copy link
Contributor

@dayaffe dayaffe commented Sep 27, 2023

Drop support for swift 5.5 and 5.6 and upgrade to min 5.7 and max 5.9 along with associated macos and xcode upgrades.

Issue #

#1132
#1133

Description of changes

With the release of Swift 5.9, XCode 15.0, and MacOS 14.0 we need to make sure our SDK supports these new versions. In addition, by dropping support for outdated versions we are able to make use of language features introduced in Swift versions 5.5, 5.6, and 5.7.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions in comments.

@sichanyoo sichanyoo self-requested a review September 28, 2023 16:57
Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dayaffe dayaffe requested a review from jbelkins September 29, 2023 15:50
@dayaffe dayaffe merged commit 56298ea into main Sep 29, 2023
10 checks passed
@dayaffe dayaffe deleted the day/update-min-max-versions branch September 29, 2023 18:52
@awslabs awslabs deleted a comment from dayaffe Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants