Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unnecessary TODO item. #1288

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Delete unnecessary TODO item. #1288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11811e
Delete unnecessary TODO item.
Jan 5, 2024
05b31e3
Merge branch 'main' into fix/awsqueryprotocol
sichanyoo Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...ain/kotlin/software/amazon/smithy/aws/swift/codegen/awsquery/AwsQueryProtocolGenerator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ import software.amazon.smithy.swift.codegen.middleware.MiddlewareStep
import software.amazon.smithy.swift.codegen.model.ShapeMetadata

open class AwsQueryProtocolGenerator : AWSHttpBindingProtocolGenerator() {
// TODO: Rename defaultContentType to differentiate between request & response
// Requests are:
// application/x-www-form-urlencoded
// Responses are:
// text/xml
override val codingKeysGenerator = DefaultCodingKeysGenerator(CodingKeysCustomizationXmlName())
override val defaultContentType = "application/x-www-form-urlencoded"
override val defaultTimestampFormat = TimestampFormatTrait.Format.DATE_TIME
Expand Down
Loading