Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .spi.yml #1297

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Update .spi.yml #1297

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
996ed7d
Update .spi.yml
finestructure Jan 11, 2024
fd9258e
Merge branch 'main' into patch-1
dayaffe Jan 11, 2024
e0f5e4f
Merge branch 'main' into patch-1
jbelkins Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .spi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,5 @@
version: 1
builder:
configs:
- platform: macosXcodebuild
target: AWSSTS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macosXcodebuild doesn't support the target flag, it needs scheme instead. (--target is a swift build parameter, --scheme an xcodebuild parameter. We should perhaps have collapsed them into one but it wasn't clear at the time if they'd be used synonymously.)

- platform: ios
target: AWSSTS
- platform: linux
swift_version: '5.7'
image: registry.gitlab.com/finestructure/spi-images:basic-5.7-latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry.gitlab.com/finestructure/spi-images:basic-5.7-latest is the default image, so this parameter is superfluous.

target: AWSSTS
- platform: linux
swift_version: '5.8'
image: registry.gitlab.com/finestructure/spi-images:basic-5.8-latest
target: AWSSTS
- platform: linux
swift_version: '5.9'
image: registry.gitlab.com/finestructure/spi-images:basic-5.9-latest
target: AWSSTS

- target: AWSSTS
scheme: AWSSTS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this can just be condensed to setting both target and scheme for all platform/Swift version combos because they'll be ignored if they don't apply.

Loading