feat!: XML response deserialization #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
requested changes
Feb 8, 2024
Sources/Core/AWSClientRuntime/Protocols/Ec2Query/Ec2Response.swift
Outdated
Show resolved
Hide resolved
...main/kotlin/software/amazon/smithy/aws/swift/codegen/awsjson/AwsJson1_0_ProtocolGenerator.kt
Show resolved
Hide resolved
...lin/software/amazon/smithy/aws/swift/codegen/restxml/AWSHttpProtocolRestXMLCustomizations.kt
Show resolved
Hide resolved
jbelkins
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
harsh62
reviewed
Feb 21, 2024
| @@ -56,14 +62,36 @@ class S3ErrorIntegration : SwiftIntegration { | |||
| private val httpResponseBinding = SectionWriter { writer, _ -> | |||
| val ctx = writer.getContext("ctx") as ProtocolGenerator.GenerationContext | |||
| val errorShapes = writer.getContext("errorShapes") as List<StructureShape> | |||
| writer.write("let restXMLError = try await \$N.makeError(from: httpResponse)", AWSClientRuntimeTypes.RestXML.RestXMLError) | |||
There was a problem hiding this comment.
This has resulted in a regression issue when we get 404 errors from S3. An example, if we call the following API with an object that does not exist, it should throw a NotFound error, instead throws a RestXMLDecodeError.missingRequiredData
try await s3Client.headObject(...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#964
Description of changes
Uses a new first-party system for deserializing XML responses and errors, replacing the
XMLCoderthird-party Swift coder for XML.AWSClientRuntimeTeststhat were just copied from protocol testsSerdeContextis unused, and is removedAWSHttpRequestXMLEncoderandAWSHttpResponseXMLDecoderare removed, since XML no longer uses decodersAlso:
.getOrNull()"syntactic sugar" method for converting Java optional to Kotlin nullable with Kotlin built-in.orElse(null)New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change. The
XMLCoderthird-party Swift package is removed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.