Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve data after reading response body stream in S3/200 middleware #1303

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix: Preserve data after reading response body stream in S3/200 middleware #1303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc62f88
Preserve data after reading response body stream
jbelkins Jan 18, 2024
a557edd
Merge branch 'main' into jbe/s3_200_stream_fix
jbelkins Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Core/AWSClientRuntime/Middlewares/AWSS3ErrorWith200StatusXMLMiddleware.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,12 @@ public struct AWSS3ErrorWith200StatusXMLMiddleware<OperationStackOutput>: Middle
return response
}

response.httpResponse.body = .data(data)

let xmlString = String(data: data, encoding: .utf8) ?? ""
if xmlString.contains("<Error>") {
// Handle the error as a 500 Internal Server Error
var modifiedResponse = response
let modifiedResponse = response
modifiedResponse.httpResponse.statusCode = .internalServerError
return modifiedResponse
}
Expand Down
Loading