feat: Add support for flexible checksums on streaming payloads #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
dayaffe
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
jbelkins
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
I have fixed several issues in this feature, both in this PR and in smithy-lang/smithy-swift#659.
Some refactoring & performance improvements are required, but will be done in a separate PR.
2 tasks
dayaffe
commented
Mar 21, 2024
| // shouldSignHeaders block was not provided, then include all headers other | ||
| // than Transfer-Encoding. | ||
| let modifiedShouldSignHeader = { (name: String) in | ||
| guard name.lowercased(with: Locale(identifier: "en_US_POSIX")) != "transfer-encoding" else { return false } |
There was a problem hiding this comment.
what's the reason for checking en_US_POSIX locale?
There was a problem hiding this comment.
If you don't specify the locale for the date & string operations that are locale-dependent, then you get the locale that the user sets as default on their device. And that may not result in lowercasing like you expected.
(I have had this happen with datetime stamps in the past, not with lowercasing, but the same risk is present)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1319
Description of changes
Also:
Transfer-Encodingheader from AWS signature calculations, since it is sometimes modified superficially by the HTTP client immediately before sending a HTTP request, causing a signature mismatch.New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.