chore: Improve AWSS3 SigV4A integration tests to use preexisting MRAP if applicable. #1370
Conversation
sichanyoo
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
| accountId: accountId, | ||
| name: mrapName | ||
| )).accessPoint?.status | ||
| } while status == .creating |
There was a problem hiding this comment.
Do we need to have some sort of timeout mechanism for this repeat loop?
There was a problem hiding this comment.
Added a simple polling limit of 20 with poll count incrementing by 1 each time.
| // Wait until MRAP creation finishes | ||
| var status: S3ControlClientTypes.MultiRegionAccessPointStatus? = .creating | ||
| repeat { | ||
| let seconds = 20.0 |
There was a problem hiding this comment.
nit: use TimeInterval type for a number of seconds
There was a problem hiding this comment.
Changed as suggested.
| // MRAP must be deleted before deleting the linked bucket | ||
| try await deleteMRAP() | ||
| // Empty & delete the bucket | ||
| try await super.tearDown() |
There was a problem hiding this comment.
This test class inherits S3XCTestCase, which does have a tear-down... we do call super.setUp() at least in some cases, which creates a test bucket... do we need to call super.tearDown() as well?
There was a problem hiding this comment.
The super.tearDown() deletes the bucket that was created in super.setUp(), but since we're keeping the MRAP, we can't delete the bucket. To delete the bucket, we have to delete MRAP first. Otherwise it would result in an error.
sichanyoo
temporarily deployed
to
Codegen-Build-Test
GitHub Actions
Inactive
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
had a problem deploying
to
Integration-Test
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
Issue #
#1371
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.