feat: Add eventstream input support for protocols that use XML for requests #1404
Conversation
…tObjectContent API. This test will fail until XML deserialization gets fixed to handle empty payload. The test is confirmed to pass after modifying EndEvent's readingClosure to check whether the type has any properties and returning a new instance instead of nil if the struct has no properties.
…ors & MessageUnmarshallableGenerators to it for organization.
…sageMarshallableGenerator, but uses closures for serialization & generates static closure variable named marshal instead of conformance to MessageMarshallable for the streaming union shapes.
…, replacing the call to MessageMarshallableGenerator.renderNotImplemented that printed error comment that said it's not implemented yet.
…sure as argument instead of requestEncoder during initialization.
sichanyoo
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
had a problem deploying
to
Codegen-Build-Test
GitHub Actions
Failure
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
sichanyoo
temporarily deployed
to
Integration-Test
GitHub Actions
Inactive
| @@ -0,0 +1,62 @@ | |||
| // | |||
There was a problem hiding this comment.
An integration test that tests the event stream output x restXml combo using S3:SelectObjectContent API.
| @@ -4,6 +4,8 @@ | |||
| */ | |||
There was a problem hiding this comment.
This and package changes that follow are due to moving message marshal/unmarshal generators into a subdirectory for organization.
| @@ -0,0 +1,182 @@ | |||
| package software.amazon.smithy.aws.swift.codegen.message | |||
There was a problem hiding this comment.
Virtually the same as MessageMarshallableGenerator but uses closures for serializing instead of encoder, and generates marshal as static function variable instead of as conformance to MessageMarshallable protocol. The marshallable generators & unmarshallable generators should both be refactored down the line to reduce code duplication. For now, followed the same decision that the XMLMessageUnmarshallableGenerator has taken.
| @@ -62,6 +63,14 @@ class RestXmlProtocolGenerator : AWSHttpBindingProtocolGenerator() { | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Use the new XMLMessageMarshallableGenerator.
| @@ -216,7 +216,7 @@ extension EventStreamTestClientTypes.TestStream: ClientRuntime.MessageUnmarshall | |||
| operation.buildStep.intercept(position: .before, middleware: AWSClientRuntime.UserAgentMiddleware(metadata: AWSClientRuntime.AWSUserAgentMetadata.fromConfig(serviceID: serviceName, version: "1.0.0", config: config))) | |||
There was a problem hiding this comment.
Updates preexisting codegen test.
| @@ -0,0 +1,140 @@ | |||
| package software.amazon.smithy.aws.swift.codegen.restxml | |||
There was a problem hiding this comment.
Codegen tests for the new XML event stream input code path.
… marshalClosure and initialRequest arguments passed to EventStreambodyMiddleware construction.
Issue #
#1379
Companion PR: smithy-lang/smithy-swift#680
Description of changes
Currently the Swift SDK does not support event stream input for protocols that use XML as request wire protocol (e.g., restXml).
Fortunately, currently there is no AWS service that uses restXml AND uses event stream input for an operation in their API either.
However, if any service that uses restXml adds an operation that takes in an event stream input in the future, our SDK would break the customers.
This PR and the companion PR in
smithy-swiftlinked above do the groundwork for supporting event stream input for protocols that use XML as request wire protocol (e.g., restXml).Detailed descriptions of each change will be put as comments on the Github diff.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.