chore: update config properties overrides #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
approved these changes
Apr 11, 2024
sichanyoo
approved these changes
Apr 11, 2024
AndrewFossAWS
force-pushed
the
feat/test-package
branch
from
b47654e to
d66a43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smithy-swiftandaws-sdk-swiftauthSchemeResolveruses:DefaultS3AuthSchemeResolver()inaws-sdk-swiftClientRuntime.AuthSchemeResolverinsmithy-swiftThe idea is that people can add their own custom client config properties in
SwiftIntegration.However the code generator doesn't validate/error on duplicate properties. (The responsibility to ensure uniqnuess falls on the people adding the properties)
In the scenario where we have to override the default client config properties from
smithy-swift(see above),HttpProtocolServiceClient.overrideConfigPropertiesmethod can be used to resolve the properties.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.