chore: Add privacy manifest & Bump crt to v0.30.0 #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 17, 2024 12:22
…pp ID, etc. collected for constructing user agent. Add manifest under resources for AWSClientRuntime target. Update base package manifest with same change.
…nResolver. Caught because this causes issue with bundling priacy manifest file into library target.
jbelkins
approved these changes
Apr 18, 2024
sichanyoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
privacy manifest: #1191
crt versionbump: #1442
Description of changes
Adds a privacy manifest. The "OtherDiagnosticData" refers to data that's collected to construct the user agent header in requests sent to AWS, which is used for performance metrics by the SDK team.
The two deleted files are unused files that are related to
BundleRegionProviderwhich was added with this PR, after which it was removed with this PR. Turns out theBundledeclaration from straggling, unused file causes issues when bundling resources for mac OS.Also, bump aws-crt-swift version to 0.30.0 to include privacy manfiest file added to that as well.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.