Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor endpoints resolver to extend from smithy-swift #1454

Merged
merged 3 commits into from
May 13, 2024

Conversation

AndrewFossAWS
Copy link
Contributor

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AndrewFossAWS AndrewFossAWS force-pushed the endpoints branch 4 times, most recently from 3093bc3 to ba58b22 Compare April 24, 2024 17:57
@AndrewFossAWS AndrewFossAWS marked this pull request as ready for review April 24, 2024 18:54
Copy link
Contributor

@syall syall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are in smithy-lang/smithy-swift#699

@AndrewFossAWS AndrewFossAWS force-pushed the endpoints branch 8 times, most recently from 90a3c88 to c13ba4c Compare May 9, 2024 15:51
@AndrewFossAWS AndrewFossAWS merged commit 7824221 into main May 13, 2024
29 checks passed
@AndrewFossAWS AndrewFossAWS deleted the endpoints branch May 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants