Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move struct encode/decode to HTTPBindingProtocolGenerator #1503

Merged
merged 2 commits into from
May 16, 2024

Conversation

jbelkins
Copy link
Contributor

Description of changes

renderStructEncode() and renderStructDecode() methods are moved into HTTPBindingProtocolGenerator (in smithy-swift), so they are deleted in the AWS-specific protocol generator subclass.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested review from dayaffe and sichanyoo May 16, 2024 15:42
@jbelkins jbelkins merged commit 6b33576 into main May 16, 2024
29 checks passed
@jbelkins jbelkins deleted the jbe/20240516_protocol_generator_refactor branch May 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants