Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enabled swiftlint on modules, added import rules #1570

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jbelkins
Copy link
Contributor

Description of changes

  • Swiftlint was not running on any of the new AWS modules. This is fixed, along with a few lint violations in those files
  • New rules are added for sorted & unused imports (duplicate imports is enabled by default.)

Note that Swiftlint will fix the new import rules automatically by running swiftlint --fix.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested review from dayaffe and sichanyoo June 13, 2024 22:25
@jbelkins jbelkins merged commit 6da9ae3 into main Jun 14, 2024
29 checks passed
@jbelkins jbelkins deleted the jbe/swiftlint_update branch June 14, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants