Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct query items in presigned URLs, add integration tests #1573

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

jbelkins
Copy link
Contributor

Issue #

#1222

Description of changes

In completing #1566, it appears that query items in presigned URLs are rendered incorrectly.
This PR corrects the rendering, regenerates the affected operations, and adds presigned URL integration tests to test for future regression.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested review from dayaffe and sichanyoo June 14, 2024 21:41
@jbelkins jbelkins merged commit 141c120 into main Jun 14, 2024
29 checks passed
@jbelkins jbelkins deleted the jbe/fix_get_query_item_middleware branch June 14, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants