Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Standalone integration test package #1585

Merged
merged 20 commits into from
Jun 25, 2024
Merged

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jun 20, 2024

Issue #

#1550

Description of changes

  • Add a new Package.swift under IntegrationTests/ to separate out integration test from main package under aws-sdk-swift/.
  • Remove integration test things from package codegen, Package.Base.swift, and CI.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about why integration test related stuff remains in main Package.swift.

@sichanyoo sichanyoo requested a review from jbelkins June 25, 2024 17:44
@sichanyoo sichanyoo force-pushed the feat/integ-test-package branch from 3d0102f to a917d77 Compare June 25, 2024 17:46
@sichanyoo sichanyoo mentioned this pull request Jun 25, 2024
…e handled the same way as smithy runtime (behavior determiend by env var).
IntegrationTests/Package.swift Outdated Show resolved Hide resolved
@sichanyoo sichanyoo requested a review from jbelkins June 25, 2024 21:43
@sichanyoo sichanyoo merged commit bc9e543 into main Jun 25, 2024
29 checks passed
@sichanyoo sichanyoo deleted the feat/integ-test-package branch June 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants