feat!: Standalone protocol test package #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 25, 2024 08:57
…lag from AWSSDKSwiftCLI package generation.
jbelkins
requested changes
Jun 25, 2024
scripts/protogen.sh
Outdated
| cd AWSSDKSwiftCLI | ||
| swift run AWSSDKSwiftCLI generate-package-manifest --include-protocol-tests --exclude-aws-services --exclude-runtime-tests .. | ||
| swift run AWSSDKSwiftCLI generate-package-manifest --exclude-aws-services --exclude-runtime-tests .. |
There was a problem hiding this comment.
I don't think we need this step for regenerating Package.swift at all anymore. None of the AWS service clients are used in protocol tests
There was a problem hiding this comment.
Deleted as suggested.
| @@ -4,7 +4,7 @@ set -e | |||
|
|
|||
| # Regenerate the SDK Package.swift to run only protocol tests and runtime unit tests | |||
There was a problem hiding this comment.
I don't think we need this comment at all anymore
There was a problem hiding this comment.
Deleted as suggested.
jbelkins
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1551
Description of changes
In logical order, from top to bottom:
Package.swiftfor protocol tests, under codegen/.addProtocolTests()function from thePackage.Base.swift.includeProtocolTestsflag andaddProtocolTests()function call codegen from AWSSDKSwiftCLI package codegen.includeProtocolTestsflag from where they're used in scripts.Package.swiftunder codegen/.New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.