feat: Add concurrent integration test & utils #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
requested changes
Jul 2, 2024
added 6 commits
July 5, 2024 12:47
jbelkins
requested changes
Jul 12, 2024
IntegrationTests/Services/AWSS3IntegrationTests/S3ConcurrentTests.swift
Outdated
Show resolved
Hide resolved
added 7 commits
September 18, 2024 10:10
sichanyoo
changed the title
added 5 commits
September 20, 2024 15:13
…ift into feat/concurrent-tests
jbelkins
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
Tests still seem to take quite a while (10 sec per test on Linux+CRT, 30 per sec on Mac+URLSession) but I'm approving because the tests do what they are supposed to do.
If we want to adjust the number of concurrent runs or the test duration, we can do that at a later time.
jbelkins
added a commit
that referenced
this pull request
Oct 28, 2024
* Add concurrent tests * Add missing 100x to a test's name * Remove 100MiB file and generate file instead. * See if using UUID for filename fixes this possibly-concurrency-issue. * Try temporaryDirectory property. * Fix concurrency issue * Comment fixes & remove STS getCallerIdentity concurrent calls. * Remove unused import * Remove concurrent test for event stream output * Refactor tests a bit * Use FileStream to write to file * Swap out filemanager with writing emtpy data approach * Tweak a bit * Simplify; no need to safe generated dummy data to a file, just use 50MB memory. * Change from 10x50MB to 100x5MB * Reduce payload from 5MB to 3MB * Reduce payload from 3MB to 1MB. * Add test for 1.5 MB to test aws chunked & flexible checksum flow also. --------- Co-authored-by: Sichan Yoo <chanyoo@amazon.com> Co-authored-by: Josh Elkins <jbelkins@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1561
Description of changes
countnumber of times, idea taken from draft PR: feat: Add concurrent integration tests #1484New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.