Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prevent node 20 from running on AL2, fix transcribe expectation #1607

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Jul 5, 2024

Issue #

#1608

Description of changes

  • Disable the forcing of Github Actions onto Node 20 since AL2 is incompatible with that version of Node.
  • The Transcribe Streaming integration test transcription has been changed slightly by the service. Verification of the transcription is now case-insensitive, and allows for any of the previous variations that the service has returned.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins changed the title chore: Prevent node 20 from running on AL2 chore: Prevent node 20 from running on AL2, fix transcribe expectation Jul 5, 2024
@jbelkins jbelkins requested review from dayaffe and sichanyoo July 5, 2024 18:43
@jbelkins jbelkins marked this pull request as ready for review July 5, 2024 18:43
@jbelkins jbelkins merged commit 83b096a into main Jul 5, 2024
28 checks passed
@jbelkins jbelkins deleted the jbe/al2_node_fix branch July 5, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants