chore: AWS model files renamed without version #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
changed the title
sichanyoo
reviewed
Jul 16, 2024
| @@ -1,2 +1,2 @@ | |||
| # Only include services needed for running integration tests | |||
| onlyIncludeModels=kinesis.2013-12-02,s3.2006-03-01,sso-admin.2020-07-20,transcribe-streaming.2017-10-26,sqs.2012-11-05,mediaconvert.2017-08-29,sts.2011-06-15,cognito-identity.2014-06-30,iam.2010-05-08,ec2.2016-11-15,ecs.2014-11-13,cloudwatch-logs.2014-03-28,s3-control.2018-08-20,eventbridge.2015-10-07,cloudfront.2020-05-31,cloudfront-keyvaluestore.2022-07-26,route-53.2013-04-01,glacier.2012-06-01 | |||
| onlyIncludeModels=kinesis,s3,sso-admin,transcribe-streaming,sqs,mediaconvert,sts,cognito-identity,iam,ec2,ecs,cloudwatch-logs,s3-control,eventbridge,cloudfront,cloudfront-keyvaluestore,route-53,glacier | |||
sichanyoo
approved these changes
Jul 16, 2024
jbelkins
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1635
Description of changes
smithy-json model files contained in
codegen/sdk-codegen/aws-modelsare no longer named with<sdkID>.<version>.json; they are now named<sdkID>.json. Version is now omitted for:(1) simplicity; and
(2) version is not a required field and a service recently shipped without version set.
To make this change:
updatemodels.shscript has been updated to write model files to the new filename.sdk.propertiesand other places that specific model identifiers are configured have been updated to drop version from the model identifiers.Models and service clients have been updated with the new
updatemodels.shscript so that the new configuration may be tested in CI.For comparison, other SDKs do not name their models with version either:
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.