Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update logging article in DocC documentation #1672

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Aug 9, 2024

Companion PR: smithy-lang/smithy-swift#797

Issue #

Description of changes

  • Update logging section in DocC article

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jackguo709
Copy link

The SDKLoggingSystem initializer is inaccessible due to 'internal' protection level.

@sichanyoo
Copy link
Contributor Author

The SDKLoggingSystem initializer is inaccessible due to 'internal' protection level.

@jackguo709

The public initializer is added in companion PR: smithy-lang/smithy-swift#797

Forgot to link it in PR description, adding now 😄

@sichanyoo sichanyoo merged commit 6e4cd78 into main Aug 13, 2024
29 checks passed
@sichanyoo sichanyoo deleted the chore/misc-logging-changes branch August 13, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants