feat: Make models Sendable #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Sep 23, 2024
...gen/protocol-test-codegen-local/Tests/swift-codegen/Tests/WaitersTests/WaiterTestUtils.swift
Outdated
Show resolved
Hide resolved
jbelkins
commented
Sep 23, 2024
| @@ -15,22 +15,21 @@ class S3ExpiresTest { | |||
| val context = setupTests("s3-expires.smithy", "com.amazonaws.s3#S3", "S3") | |||
| val contents = TestUtils.getFileContents(context.manifest, "Sources/Example/models/FooOutput.swift") | |||
| contents.shouldSyntacticSanityCheck() | |||
There was a problem hiding this comment.
Tests fixed below, which were affected by the changes made in smithy-swift.
jbelkins
commented
Sep 23, 2024
| // Use of fully-qualified type names in this extension suppresses the Swift 6 | ||
| // "retroactive conformance" warning in a manner compatible with Swift 5. | ||
| // See: https://github.com/swiftlang/swift-evolution/blob/main/proposals/0364-retroactive-conformance-warning.md#source-compatibility | ||
| extension SmithyWaitersAPI.WaiterConfiguration.Acceptor.Match: Swift.Equatable where Input: Swift.Equatable, Output: Swift.Equatable { |
There was a problem hiding this comment.
Using fully-qualified names in an extension declaration suppresses "retroactive conformance" warnings while still being compatible with Swift 5.x (using @retroactive in Swift 5 results in a compile error.)
…s/aws-sdk-swift into jbe/sendable_document_and_streams
sichanyoo
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1768
Description of changes
smithy-lang/smithy-swift#829 makes generated models
Sendable.This PR fixes some affected codegen tests and a couple of Swift 6 compile warnings.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.