Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use Github macOS runner for swiftlint #662

Merged
merged 7 commits into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@ jobs:
run: |
./gradlew ktlint
swiftlint:
runs-on: ubuntu-latest
runs-on: macos-latest
steps:
- name: Checkout sources
uses: actions/checkout@v2
- name: Swift Lint ClientRuntime
uses: norio-nomura/action-swiftlint@3.2.1
with:
args: --path ./AWSClientRuntime --config ./AWSClientRuntime/.swiftlint.yml
- name: Run swiftlint on AWSClientRuntime
run: swiftlint --reporter github-actions-logging --path ./AWSClientRuntime --config ./AWSClientRuntime/.swiftlint.yml
3 changes: 2 additions & 1 deletion AWSClientRuntime/Sources/IMDS/IMDSClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import ClientRuntime
///
/// This client supports fetching tokens, retrying failures, and token caching according to the specified TTL.
/// NOTE: This client ONLY supports IMDSv2. It will not fallback to IMDSv1.
/// See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html#instance-metadata-transition-to-version-2 for more information.
/// See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/configuring-instance-metadata-service.html#instance-metadata-transition-to-version-2
/// for more information.
public class IMDSClient {
let crtIMDSClient: CRTIMDSClient
private let sharedDefaultIO: SDKDefaultIO = SDKDefaultIO.shared
Expand Down