Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: update shape and member extensions to use same casing as rest of the system #684

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Nov 8, 2022

Issue #

Description of changes

Motivation

While doing testing figured due to casing change UseFIPS is not translate to useFIPS by preserving the captalization for FIPS which is expected. This change broke the build because the config is named as useFips.

Changes

Result

Code compiles

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ganeshnj ganeshnj marked this pull request as ready for review November 8, 2022 00:09
@jbelkins
Copy link
Contributor

jbelkins commented Nov 8, 2022

Should we build a release on this branch as a retest?

@ganeshnj ganeshnj merged commit a89ec7b into main Nov 8, 2022
@ganeshnj ganeshnj deleted the jangirg/fix/remaining-caseing branch November 8, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants