chore: Adds new workflow for building the full sdk #802
Conversation
|
IMHO, this new workflow is redundant to CI job. What we should do it to make CI do all of this so we get the feedback early. I totally understand the timing issue as it will take a while to build, but there are ways to speed up the build process for example batching the build to separate hosts
|
|
@ganeshnj i agree, do we think it's acceptable to add this now (we can remove it when we add this functionality to the CI job). I'll file an issue to address adding this functionality to the CI job. |
| chmod a+x builder.pyz | ||
| AWS_CRT_SWIFT_CI_DIR="${{ env.AWS_CRT_SWIFT_CI_DIR }}" AWS_SDK_SWIFT_CI_DIR="${{ env.AWS_SDK_SWIFT_CI_DIR }}" SMITHY_SWIFT_CI_DIR="${{ env.SMITHY_SWIFT_CI_DIR }}" ./builder.pyz build -p ${{ env.PACKAGE_NAME }} | ||
| ./gradlew -p codegen/sdk-codegen build | ||
| rm -rf release/ |
There was a problem hiding this comment.
this is worrying, we must root cause what is being generated/added that causes us to remove the dir.
backlog is fine as of now. We must keep this workflow trigger to manual dispatch. |
This PR adds a workflow for regenerating all models, building the full sdk (models included) and running tests.
Issue #
#801
Description of changes
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.