Return correct response for creating instances and bindings that alre… #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiresky
changed the title
|
@vsomayaji can you please review? |
|
Apologies for the delay @shiresky and thank you for the contribution. Merging now and will hopefully have a new release cut shortly. |
|
after doing some testing for release it seems this pr is causing a few tests to fail, I'm going to revert this merge to unblock release for the time being. @shiresky if you would still like this merged can you please have a look at the failing tests, resolve and open a new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
aws-servicebroker does not implement OSB specification correctly. It causes issues with creating K8s service catalog ServiceInstances and ServiceBindings representations for instances and bindings that already exists in broker's database (were created previously with use of plain OSB API).
Testing
Changes were tested by:
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.