Added support for unsigned_payload. New services such as Lattice does… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't support signed payload yet.
alvinlin123
reviewed
Mar 3, 2023
alvinlin123
reviewed
Mar 3, 2023
alvinlin123
reviewed
Mar 3, 2023
handler/proxy_client.go
Outdated
| @@ -43,6 +43,7 @@ type ProxyClient struct { | |||
| HostOverride string | |||
| RegionOverride string | |||
| LogFailedRequest bool | |||
| UnsignedPayload bool | |||
There was a problem hiding this comment.
Is this variable used, do we need this variable in this struct?
There was a problem hiding this comment.
Corrected. It would be great if we can merge this PR as it is blocking the launch blog.
alvinlin123
reviewed
Mar 3, 2023
|
@alvinlin123 Alvin Lin, can you please review and merge this PR. Amazon VPC Lattice, can use this proxy and this PR merge will be helpful. |
alvinlin123
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n't support signed payload yet.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.