(aws-cloudfront-s3): cloudFrontDistributionProps autocomplete is not populating

[robertd]

cloudFrontDistributionProps autocomplete is not populating

Reproduction Steps

import * as acs3 from '@aws-solutions-constructs/aws-cloudfront-s3';

new acs3.CloudFrontToS3(this, "test", {
      deployBucket: true,
      cloudFrontDistributionProps: {
        
      },
      bucketProps: {
        bucketName: "test"
      },
    });

Environment

• CDK CLI Version : 1.46.0
• CDK Framework Version: 1.46.0
• AWS Solutions Constructs Version : 1.46.0
• OS : MacOS
• Language : Typescript

Other

---

This is 🐛 Bug Report

[robertd]

When I try to override the property...

I'm getting a warning:

WARN AWS_SOLUTIONS_CONSTRUCTS_WARNING: An override has been provided for the property: undefined.

[GerardKetuma]

There is a bug in the s3-bucket-helper function s3BucketWithLogging on the following line:

aws-solutions-constructs/source/patterns/@aws-solutions-constructs/core/lib/s3-bucket-helper.ts

Line 70 in 0780155

bucketprops = DefaultS3Props;

Currently it is:
bucketprops = DefaultS3Props;

But it should be:
bucketprops = DefaultS3Props(); as DefaultS3Props is a function that returns an object and bucketprops should be an object.

I'm creating a PR to resolve the issue.

[hnishar]

robertd@ the PR has been merged and that should fix the override warning message..

Regarding the autocomplete issue, CloudFrontToS3Props has cloudFrontDistributionProps declared as cloudfront.CloudFrontWebDistributionProps | any.. due to the any type the IDE is probably not doing the autocomplete.. the any type is required otherwise the caller will need to set the mandatory originConfigs property of S3 bucket that is yet to be created by the pattern