Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in s3BucketWithLogging function #9

Closed

Conversation

GerardKetuma
Copy link

In the s3BucketWithLogging function, bucketprops gets passed a function instead of the function's output, which is an object.

Issue #, if available:
I think this is what is causing the following issue:
#5

Description of changes:
Called the DefaultS3Props helper function instead of passing the function.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…ssed a function instead of the function's output, which is an object.
@hnishar
Copy link
Contributor

hnishar commented Jun 25, 2020

GerardKetuma@ Thanks for the contribution, it has been merged into the latest release v1.47.0

@hnishar hnishar closed this Jun 25, 2020
aws-solutions-constructs-team pushed a commit that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants