Fix bug in s3BucketWithLogging function #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed a function instead of the function's output, which is an object.
|
GerardKetuma@ Thanks for the contribution, it has been merged into the latest release v1.47.0 |
aws-solutions-constructs-team
pushed a commit
that referenced
this pull request
Mar 17, 2023
chore(release): 2.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the s3BucketWithLogging function, bucketprops gets passed a function instead of the function's output, which is an object.
Issue #, if available:
I think this is what is causing the following issue:
#5
Description of changes:
Called the DefaultS3Props helper function instead of passing the function.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.