This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
replace-ascii-parsing-with-utf-8 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 5 5
Lines 317 317
Branches 42 42
======================================
Hits 311 311
Misses 3 3
Partials 3 3
Continue to review full report at Codecov.
|
|
Hey, I am not a maintainer - just someone trying to make this work, but I noticed there were other instances - all tests - that use this as well and this patch should probably fix them too: https://github.com/awslabs/awsprocesscreds/search?q=ascii&unscoped_q=ascii |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When attempting login and return token for aws with adfs the program produces this error:
File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/awsprocesscreds/saml.py", line 423, in _parse_roles root = ET.fromstring(base64.b64decode(assertion).decode('ascii')) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 10504: ordinal not in range(128)When passed credentials containing only ascii characters. Further inspection revealed if a user has 17 roles the login fails with above error. Normal login works as expected.
Description of changes:
Changed decoding from ascii to utf-8. Issue was resolved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.