Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update webpack configure and support js file integrate #15

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. update webpack configure and support js file integrate.
  2. fix the issue for window.document is null when integrate by js file.

General Checklist

  • Added new tests to cover change, if needed
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (821918c) 100.00% compared to head (c4e9fdc) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          953       964   +11     
  Branches       172       176    +4     
=========================================
+ Hits           953       964   +11     
Files Changed Coverage Δ
src/tracker/ClickTracker.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane requested a review from chenhaiyun August 30, 2023 08:45
package-lock.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
test/tracker/ClickTracker.test.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@zxkane zxkane merged commit 3b01919 into main Aug 31, 2023
4 checks passed
@zxkane zxkane deleted the webpack_configure branch August 31, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants