fix: scopes should not be filtered in search use cases (#79)

awslabs · Mar 11, 2022 · 67af26d · 67af26d
1 parent 4e4d796
commit 67af26d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/smartScopeHelper.test.ts b/src/smartScopeHelper.test.ts
@@ -395,6 +395,20 @@ describe('filterOutUnusableScope', () => {
             ),
         ).toEqual(['system/*.write']);
     });
+
+    test('do not filter patient scope out in type-search use case', () => {
+        const clonedScopeRule = emptyScopeRule();
+        clonedScopeRule.system.read = ['search-type'];
+        expect(
+            filterOutUnusableScope(
+                ['system/DocumentReference.read', 'system/Patient.read'],
+                clonedScopeRule,
+                'search-type',
+                false,
+                'DocumentReference',
+            ),
+        ).toEqual(['system/DocumentReference.read', 'system/Patient.read']);
+    });
 });
 
 describe('getValidOperationsForScopeTypeAndAccessType', () => {

diff --git a/src/smartScopeHelper.ts b/src/smartScopeHelper.ts
@@ -55,7 +55,7 @@ function getValidOperationsForScope(
     let validOperations: (TypeOperation | SystemOperation)[] = [];
     const { scopeType, resourceType, accessType } = smartScope;
     if (reqResourceType) {
-        if (resourceType === '*' || resourceType === reqResourceType) {
+        if (resourceType === '*' || resourceType === reqResourceType || reqOperation === 'search-type') {
             validOperations = getValidOperationsForScopeTypeAndAccessType(scopeType, accessType, scopeRule);
         }
     }