This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: support string array in OAuth aud claim #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilhdiaz
force-pushed
the
audience-array
branch
2 times, most recently
from
40d899a to
9402fb8
Compare
rsmayda
reviewed
Nov 10, 2020
emilhdiaz
force-pushed
the
audience-array
branch
from
9402fb8 to
454bdea
Compare
rsmayda
suggested changes
Nov 11, 2020
emilhdiaz
force-pushed
the
audience-array
branch
from
454bdea to
14e1db0
Compare
|
Ah yep, just did. It's my first time writing unit tests in jest, so hopefully I implemented the tests correctly. |
rsmayda
approved these changes
Nov 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
As per rfc7519:
This change allows the
audclaim in theaccess_tokenJWT to be either astringorstring[](string array).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.