Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: pass params in url for introspect jwt flow #48

Merged
merged 2 commits into from
Aug 5, 2021

Conversation

medhost-jshaver
Copy link
Contributor

Returning the decoded JWT token payload from introspectJwtToken function, and using string token parameter for call to introspect endpoint since it expects x-www-form-urlencoded content-type.

Issue #, if available:

Description of changes:

  1. Changed introspectJwtToken method to return the decoded token payload since the introspect endpoint response doesn't necessarily return the JWT.

For example, our introspect endpoint returns a payload with the "scope" key while the jwt uses "scp".

  1. change the token parameter type to a string for the actual introspect call. The Object structure did not seem to place nice with x-www-form-urlencoded content-type.

  2. Updated test to reflect the introspectJwtToken returning the decodedToken payload and not the introspect response.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ion. Also using string token parameter for call to introspect endpoint since it expects x-www-form-urlencoded content-type.
@rsmayda rsmayda changed the title Small fix for introspect jwt flow fix: Small fix for introspect jwt flow Aug 4, 2021
@rsmayda rsmayda changed the title fix: Small fix for introspect jwt flow fix: pass params in url for introspect jwt flow Aug 4, 2021
Copy link
Contributor

@rsmayda rsmayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@medhost-jshaver please commit an empty commit with a commit message following conventional commits. Something like the below would work:
fix: pass params in url for introspect jwt flow

@carvantes or @Bingjiling to merge this in and release it.

@carvantes carvantes merged commit d67b693 into awslabs:mainline Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants