Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: remove filtered responses from total count #63

Merged
merged 5 commits into from
Sep 13, 2021
Merged

fix: remove filtered responses from total count #63

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f3dbdf
fix: remove filtered responses from total count
ssvegaraju Sep 9, 2021
ecd9690
fix linting issue
ssvegaraju Sep 9, 2021
74436fb
fix NaN tests.
ssvegaraju Sep 10, 2021
c1a5f06
adjust tests to test for totals and properly filter NaN totals
ssvegaraju Sep 13, 2021
121c8ca
Merge branch 'mainline' into fix-incorrectFilterTotal
ssvegaraju Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/smartHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export class SMARTHandler implements Authorization {
const { operation, readResponse } = request;
// If request is a search treat the readResponse as a bundle
if (SEARCH_OPERATIONS.includes(operation)) {
const entries = (readResponse.entry ?? []).filter((entry: { resource: any }) =>
const entries: any[] = (readResponse.entry ?? []).filter((entry: { resource: any }) =>
hasAccessToResource(
fhirUserObject,
patientLaunchContext,
Expand All @@ -329,6 +329,11 @@ export class SMARTHandler implements Authorization {
this.fhirVersion,
),
);
const totalNumEntriesAfterFilter: number =
rsmayda marked this conversation as resolved.
Show resolved Hide resolved
readResponse.total - (readResponse.entry.length - entries.length);
if (totalNumEntriesAfterFilter < readResponse.total) {
readResponse.total = totalNumEntriesAfterFilter;
}
ssvegaraju marked this conversation as resolved.
Show resolved Hide resolved
return { ...readResponse, entry: entries };
}
// If request is != search treat the readResponse as just a resource
Expand Down