Github Releases #53
Merged
Github Releases #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisidev
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: none, somehow connected with #32
Description of changes:
This PR adds a feature to publish flowgger release packages as GitHub Releases. It publishes a zip with the flowgger binary + flowgger.toml for every target in the Travis CI build. I also did some refactoring to the Travis scripts.
Example release: https://github.com/Trojan295/flowgger/releases/tag/0.1.0
Travis CI build for this release: https://travis-ci.org/Trojan295/flowgger/builds/600116381
To make it work, some Github account with rights to publish to Github Releases must generate an API key and add to Travis CI environment variables as
GITHUB_APIKEY.I also added to test/build the flowgger binary with all features except
capnp, because it requires the capnp compiler installed in the build environment. We cannot install it there, because we are using cross and would need to build custom images for every target (see cross-rs/cross#281).I also had to modify two tests for
FileOutput, because they were writing a file to a path, which is read-only in the build environment and thus failing. There are also additional modification to this file, caused bycargo fmt.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.