fix(bedrock): use CfnDataSource and construct's dataSourceId as uniqu…

…e id (fixes #470) (#471)
awslabs · May 22, 2024 · 0847c0c · 0847c0c
1 parent a8d4373
commit 0847c0c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/apidocs/classes/bedrock.S3DataSource.md b/apidocs/classes/bedrock.S3DataSource.md
@@ -55,7 +55,7 @@ Construct.constructor
 
 ### dataSource
 
-• `Readonly` **dataSource**: `CfnResource`
+• `Readonly` **dataSource**: `CfnDataSource`
 
 The Data Source cfn resource.
 

diff --git a/src/cdk-lib/bedrock/s3-data-source.ts b/src/cdk-lib/bedrock/s3-data-source.ts
@@ -11,7 +11,6 @@
  *  and limitations under the License.
  */
 
-import * as cdk from 'aws-cdk-lib';
 import { aws_bedrock as bedrock } from 'aws-cdk-lib';
 import * as kms from 'aws-cdk-lib/aws-kms';
 import * as s3 from 'aws-cdk-lib/aws-s3';
@@ -103,7 +102,7 @@ export class S3DataSource extends Construct {
   /**
    * The Data Source cfn resource.
    */
-  public readonly dataSource: cdk.CfnResource;
+  public readonly dataSource: bedrock.CfnDataSource;
   /**
    * The unique identifier of the data source.
    */
@@ -152,8 +151,7 @@ export class S3DataSource extends Construct {
 
     });
 
-    this.dataSourceId = dataSourceName;
-
+    this.dataSourceId = this.dataSource.attrDataSourceId;
   }
 }
 
@@ -208,4 +206,4 @@ function vectorIngestionConfiguration(
     return {};
   }
 
-}
+}