fix(constructs): fix log group name bug for step functions #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottschreckengaust
previously approved these changes
Dec 15, 2023
scottschreckengaust
previously approved these changes
Dec 15, 2023
scottschreckengaust
approved these changes
Dec 15, 2023
hvital
approved these changes
Dec 15, 2023
krokoko
requested review from
laithalsaadoon,
MichaelWalker-git and
dineshSajwan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tearing down/re-deploying a stack using the constructs, the user can face an issue where
This is related to an issue in IH where a log delivery policy is created (AWSLogDeliveryWrite*) and data are cumulated without being properly cleared. One way to workaround the issue is to prefix the name of the log group however that api is not exposed yet through CDK.
There is a great solution proposed by @biffgaut and implemented in the aws-solutions-constructs which we replicate here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.