Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loaders for M5 & ETT datasets #3155

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix loaders for M5 & ETT datasets #3155

merged 3 commits into from
Apr 2, 2024

Conversation

shchur
Copy link
Contributor

@shchur shchur commented Apr 2, 2024

Description of changes:

  • Fix how item_id is obtained for M5 and ETT datasets
  • Fix lxml dependency range

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@shchur shchur requested a review from abdulfatir April 2, 2024 13:37
@@ -26,7 +26,8 @@
character if set to `True`.
"""

__all__ = [ # noqa
# ruff: noqa: F822
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New ruff version complains about this, requires a fix

@shchur shchur requested review from lostella and canerturkmen April 2, 2024 14:04
@@ -3,6 +3,7 @@ ipykernel~=6.5
nbconvert~=6.5.1
nbsphinx~=0.8.8
notedown
lxml~=5.1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newly released lxml-5.2.0 breaks the doc build process, need to cap the dependency

@shchur shchur enabled auto-merge (squash) April 2, 2024 14:11
@shchur shchur merged commit 739627a into awslabs:dev Apr 2, 2024
19 checks passed
@shchur shchur deleted the fix-m5-ett branch April 2, 2024 14:15
@lostella lostella added the datasets This concerns dataset provided in the repository label May 24, 2024
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Jun 15, 2024
*Description of changes:*
- Fix how `item_id` is obtained for M5 and ETT datasets
- Fix `lxml` dependency range


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.


**Please tag this pr with at least one of these labels to make our
release process faster:** BREAKING, new feature, bug fix, other change,
dev setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets This concerns dataset provided in the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants