-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix loaders for M5 & ETT datasets #3155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shchur
commented
Apr 2, 2024
@@ -26,7 +26,8 @@ | |||
character if set to `True`. | |||
""" | |||
|
|||
__all__ = [ # noqa | |||
# ruff: noqa: F822 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New ruff version complains about this, requires a fix
shchur
commented
Apr 2, 2024
@@ -3,6 +3,7 @@ ipykernel~=6.5 | |||
nbconvert~=6.5.1 | |||
nbsphinx~=0.8.8 | |||
notedown | |||
lxml~=5.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newly released lxml-5.2.0
breaks the doc build process, need to cap the dependency
canerturkmen
approved these changes
Apr 2, 2024
kashif
pushed a commit
to kashif/gluon-ts
that referenced
this pull request
Jun 15, 2024
*Description of changes:* - Fix how `item_id` is obtained for M5 and ETT datasets - Fix `lxml` dependency range By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
item_id
is obtained for M5 and ETT datasetslxml
dependency rangeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup