Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudformation.Sub and the other intrinsics should escape JSON #194

Open
jarreds opened this issue Mar 28, 2019 · 0 comments
Open

cloudformation.Sub and the other intrinsics should escape JSON #194

jarreds opened this issue Mar 28, 2019 · 0 comments

Comments

@jarreds
Copy link
Contributor

jarreds commented Mar 28, 2019

Code in question for Sub here:

https://github.com/awslabs/goformation/blob/master/cloudformation/intrinsics.go#L113

The following minimal repro:

cloudformation.Sub(`{"foo":"bar"}`)

Will remain as base64 in the template JSON output.

Should be as easy as adding a json.Marshal into the Sub and friends functions, but unfortunately they would have to swallow or panic an error to maintain the same type signature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jarreds